Draft
Conversation
…puts Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ComputeIlcCompileInputs execution order before PrepareForILLink
Decouple NativeAOT ILLink assembly input computation from Feb 24, 2026
ComputeIlcCompileInputs
This was referenced Feb 24, 2026
…lyToLink Factor _PrepareTrimConfiguration out of PrepareForILLink so shared trim configuration operates on ResolvedFileToPublish and flows to both ILLink and ILC without duplication. For NativeAOT, _ComputeAssembliesToCompileToNative replaces CoreCLR runtime pack files with DefaultFrameworkAssemblies (tagged PostprocessAssembly=true) before _PrepareTrimConfiguration runs. _ComputeIlcCompileInputs then derives IlcReference from ResolvedFileToPublish via PostprocessAssembly metadata, ensuring ILC sees ILLink-relocated paths when both run. ComputeLinkedFilesToPublish hooks AfterTargets=ILLink (instead of ComputeResolvedFilesToPublishList) for correct ordering when both ILLink and ILC run. RunILLink is made conditional so projects can opt in. Remove ManagedAssemblies output from the C# task (replaced by ResolvedFileToPublish filtering). Add RuntimePackFilesToSkipPublish output for early removal of CoreCLR runtime pack files. Fix OOB assembly handling so overrides stay in ResolvedFileToPublish.
ComputeIlcCompileInputsSkip _ComputeIlcCompileInputs for framework library builds (BuildingFrameworkLibrary=true) since they use BuildOneFrameworkLibrary for input computation, not the publish-pipeline targets.
When NativeCompilationDuringPublish is false (e.g. Apple non-library-mode builds), Publish.targets is not imported so _ComputeIlcCompileInputs does not exist to populate IlcReference from ResolvedFileToPublish. Fall back to DefaultFrameworkAssemblies directly in ComputeIlcCompileInputs so ILC can find System.Private.CoreLib and other framework references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ComputeManagedAssemblyForILLinkin NativeAOT was indirectly dependent onComputeIlcCompileInputsvia@(ManagedBinary), which madePrepareForILLinkordering-sensitive and broke incremental ILLink behavior when ILLink is run before ILC input computation. This change removes that coupling so ILLink preparation no longer relies onComputeIlcCompileInputsside effects.What changed
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targetsin_ComputeManagedAssemblyForILLink.@(ManagedBinary)with@(IntermediateAssembly)when reconstructing@(ManagedAssemblyToLink).Why this matters
@(IntermediateAssembly)is available duringPrepareForILLink, independent ofComputeIlcCompileInputs.@(ManagedAssemblyToLink)regardless of whetherComputeIlcCompileInputsruns before or afterPrepareForILLink/ILLink.Code change
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.